design_fidelity.hpp

Go to the documentation of this file.

// core/view/include/pulp/view/design_fidelity.hpp
//
// Reference-free import-fidelity self-checks. Each invariant is a small pure
// function registered in one table; codegen captures the geometry it already
// computes and calls run_fidelity_checks() at each branch. Adding an invariant
// = one function + one registry line here — design_codegen.cpp does not grow.
//
// Every check reads only normalized DesignIR geometry + the emitted dimensions,
// never a source quirk, so all sources (figma, figma-plugin, pencil, stitch,
// v0, claude) are validated by the same checks.
#pragma once
 
#include <pulp/view/design_ir.hpp>
 
#include <cstddef>
#include <functional>
#include <optional>
#include <string>
#include <vector>
 
namespace pulp::view {

struct FidelityIssue {
    std::string node_id;    
    std::string node_name;  
    std::string kind;       
    std::string detail;     
    bool informational = false;  
};

enum class FidelityElement { image, container, widget, text };

struct FidelityContext {
    const IRNode& node;
    std::string node_id;
    float emitted_w = 0.0f;
    float emitted_h = 0.0f;
    FidelityElement element = FidelityElement::container;
};

bool is_vector_kind(const std::string& type);
 
// ── Individual invariants (pure; testable in isolation) ──────────────────────

std::optional<FidelityIssue> check_image_sizing_fidelity(const FidelityContext&);

std::optional<FidelityIssue> check_gross_size_divergence(const FidelityContext&);

std::optional<FidelityIssue> check_widget_intrinsic_size(const FidelityContext&);

std::optional<FidelityIssue> check_text_vertical_centering(const FidelityContext&);
 
// ── Registry + entry point ───────────────────────────────────────────────────

void run_fidelity_checks(const FidelityContext& ctx, std::vector<FidelityIssue>& sink);
 
// ── Tree-level invariants (need subtree / coverage context) ──────────────────

void check_vector_renderability(
    const IRNode& root,
    const std::vector<ImportDiagnostic>& diagnostics,
    const std::function<std::string(const IRNode&)>& node_id_of,
    std::vector<FidelityIssue>& sink);

std::size_t count_strict_fidelity_failures(const std::vector<FidelityIssue>& issues);
 
}  // namespace pulp::view